Conversation
The rule compiler emitted '[expr] * count' without parenthesizing the count expression, so IfcMakeArrayOfArray's '[...] * u1 - low1 + 1' evaluated as '([...] * u1) - low1', raising TypeError: unsupported operand type(s) for -: 'list' and 'int'. This broke the Weights derived attribute on IfcRationalBSplineSurfaceWithKnots and made the IfcSurfaceWeightsPositive where rule fail on valid files (buildingSMART/validate#266). Fix the template in rule_compiler.py and patch the generated rules files accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
TypeError: unsupported operand type(s) for -: 'list' and 'int'reported in buildingSMART/validate#266 (buildingSMART/validate#266).The rule compiler emitted
[expr] * countwithout parenthesizing the count expression, soIfcMakeArrayOfArray's generatedevaluated as
([...] * u1) - low1, raising a TypeError. This broke theWeightsderived attribute onIfcRationalBSplineSurfaceWithKnots, making theIfcSurfaceWeightsPositivewhere rule fail on valid files.Changes:
rule_compiler.py: aggregate initializer template now emits([expr] * (count))express/rules/IFC*.pyfiles patched accordingly (11 files withIfcMakeArrayOfArray)Verified by running the patched
IfcMakeArrayOfArrayon the weights array from the issue's#97=IfcRationalBSplineSurfaceWithKnotsinstance: no TypeError, andIfcSurfaceWeightsPositivepasses as expected.