Conversation
Entity.filter() returned ifc_file.by_type()'s result unmodified when no predefinedType was given. That result is not guaranteed to be a list (some ifcopenshell builds return a tuple), and every other facet's filter() decides whether to narrow the population handed to it, or discard it and rescan the entire model, based on isinstance(elements, list). A tuple fails that check, so the very next facet in an <ids:applicability> silently ignored the entity restriction and matched any class sharing the same attribute, classification, material, etc. value. Observed in practice: a specification scoped to entity(IFCMATERIAL) + attribute(Name=X) also matched an unrelated IfcTendonType that happened to share Name X with the IfcMaterial, failing the specification because the IfcTendonType lacks Pset_MaterialSteel. Adds a regression test that forces by_type() to return a tuple so it reproduces independent of what the local ifcopenshell build normally returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entity.filter() returned ifc_file.by_type()'s result unmodified when no predefinedType was given. That result is not guaranteed to be a list (some ifcopenshell builds return a tuple), and every other facet's filter() decides whether to narrow the population handed to it, or discard it and rescan the entire model, based on isinstance(elements, list). A tuple fails that check, so the very next facet in an ids:applicability silently ignored the entity restriction and matched any class sharing the same attribute, classification, material, etc. value.
Observed in practice: a specification scoped to
entity(IFCMATERIAL) + attribute(Name=X) also matched an unrelated IfcTendonType that happened to share Name X with the IfcMaterial, failing the specification because the IfcTendonType lacks Pset_MaterialSteel.
Adds a regression test that forces by_type() to return a tuple so it reproduces independent of what the local ifcopenshell build normally returns.
An example is shown here:
Attached are the source IFC file and the IDS. You may think the IDS is a bit weird (and it is). I am experimenting with creating an IDS that tests the outputs of a structural bridge design are retained in the IFC model as the model progresses through project development.
PGSuper_Import_Model.ifc.txt
PGSuper_Import_Model.ids.txt