Makefile - enhance wget for improved resilience during downloads #7479
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bonsai/Makefile
Outdated
|
|
||
| # jQuery is required for web UI functionality | ||
| cd build/bonsai/bim/data/webui/static/js/ && wget https://cdn.jsdelivr.net/npm/jquery@3.7.1/dist/jquery.min.js | ||
| cd build/bonsai/bim/data/webui/static/js/ && wget --tries=5 --timeout=60 --waitretry=5 --retry-connrefused --continue https://cdn.jsdelivr.net/npm/jquery@3.7.1/dist/jquery.min.js |
There was a problem hiding this comment.
Since this is largely repetetive I suggest extracting it into a function, for the benefit that functions give.
Download=cd $1 && wget --tries=5 --timeout=60 --waitretry=5 --retry-connrefused --continue $2
...
$(call Download, build/bonsai/bim/data/webui/static/js/,https://cdn.jsdelivr.net/npm/jquery@3.7.1/dist/jquery.min.js)
...
$(call Download, build, -O ifc2json.zip https://github.com/IFCJSON-Team/IFC2JSON_python/archive/refs/heads/master.zip)Haven't been doing raw gnumake for a while so syntax might be slightly off.
Contributor
Author
There was a problem hiding this comment.
Yes! Thanks for the feedback. I have updated it (also increased --waitretry=10).
Cheers!
Contributor
Author
|
@Andrej730 Do you think this is a useful addition? In general github links work properly but last week they were not working (manually they were with these parameters) and making the makefile to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the Makefile to build the addons fai due to some temporary issue to download software usign wget commands.
This is a proposal to make that a little bit more resilient.
Cheers!