Skip to content

fix: ValueError should be raised, not returned #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c00kiemon5ter merged 1 commit into from
Nov 8, 2022
Merged

fix: ValueError should be raised, not returned #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pyop/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def from_uri(cls, db_uri, collection, db_name=None, ttl=None, **kwargs):
alg=alg
)

return ValueError(f"Invalid DB URI: {db_uri}")
raise ValueError(f"Invalid DB URI: {db_uri}")

@classmethod
def type(cls, db_uri):
Expand All @@ -105,7 +105,7 @@ def type(cls, db_uri):
elif url.scheme == "stateless":
return "stateless"

return ValueError(f"Invalid DB URI: {db_uri}")
raise ValueError(f"Invalid DB URI: {db_uri}")

@property
def ttl(self):
Expand Down