fix: ValueError should be raised, not returned #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue where invalid config might lead to an ValueError object being used as a databasse object, leading to application errors later. Rather fail fast by properly raising the exception.
Member
|
Thanks! I guess this slipped through by mistake. |
vladimir-mencl-eresearch
added a commit
to REANNZ/SATOSA
that referenced
this pull request
Nov 9, 2022
With IdentityPython/pyop#44 merged, OpenIDConnectFrontend init fails when `db_uri` is not set, as `StorageBase.type` now throws a `ValueError` for db_uri values that do not match one of the recognised storage types (including when `db_uri` is `None`). Fix this by guarding the `StorageBase.type` with a pythonic test whether `db_uri` was provided. Same test already guards `StorageBase.from_uri`, add it also to the `StorageBase.type` call made to determine `self.stateless`.
3 tasks
c00kiemon5ter
pushed a commit
to IdentityPython/SATOSA
that referenced
this pull request
Nov 9, 2022
With IdentityPython/pyop#44 merged, OpenIDConnectFrontend init fails when `db_uri` is not set, as `StorageBase.type` now throws a `ValueError` for db_uri values that do not match one of the recognised storage types (including when `db_uri` is `None`). Fix this by guarding the `StorageBase.type` with a pythonic test whether `db_uri` was provided. Same test already guards `StorageBase.from_uri`, add it also to the `StorageBase.type` call made to determine `self.stateless`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where invalid config might lead to an ValueError object being used as a databasse object, leading to application errors later.
Rather fail fast by properly raising the exception.