This repository was archived by the owner on Jun 23, 2023. It is now read-only.
Separate grant_types_supported and grant_types_helpers#186
Merged
rohe merged 1 commit intoIdentityPython:developfrom Feb 24, 2022
Merged
Separate grant_types_supported and grant_types_helpers#186rohe merged 1 commit intoIdentityPython:developfrom
rohe merged 1 commit intoIdentityPython:developfrom
Conversation
rohe
approved these changes
Feb 11, 2022
peppelinux
approved these changes
Feb 19, 2022
Member
peppelinux
left a comment
peppelinux
left a comment
There was a problem hiding this comment.
Ok, good!
@nsklikas please use a conventional commit with a BREAKING CHANGE label to show to the user that the release that will bring this change will introduce problems with the preexisting configurations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate
grant_types_supportedandgrant_types_helpers.The reason behind this is that we may want to initialize some grant_type helper, but no support that grant type globally. For example, we may want to support token_exchange for only one client, the helper must be initialized, but the grant type must not be supported globally.