Skip to content
This repository was archived by the owner on Jun 23, 2023. It is now read-only.

Don't issue refresh token if not configured#128

Merged
rohe merged 2 commits intoIdentityPython:developfrom
nsklikas:feature-grant-types-fix
Sep 23, 2021
Merged

Don't issue refresh token if not configured#128
rohe merged 2 commits intoIdentityPython:developfrom
nsklikas:feature-grant-types-fix

Conversation

@nsklikas
Copy link
Contributor

This should have been in my last PR, we should respect the configured grant_types and not issue a refresh token if the refresh_token grant type is not supported

@nsklikas nsklikas requested review from peppelinux and rohe September 10, 2021 11:21
@peppelinux
Copy link
Member

It seems working good, can you fix the conflicting files?

@rohe that's for the next major realease with all the contributions in, or do we think to merge only this pr for an intermediate release?

@nsklikas nsklikas force-pushed the feature-grant-types-fix branch from d9faea7 to 5228f17 Compare September 20, 2021 11:56
@rohe
Copy link
Collaborator

rohe commented Sep 20, 2021

I have a couple of changes based on the logout testing.
Stalled because I found an error in the test suite and they are slow to fixing.
Anyway, they could hold for 2.3.0 (I think 2.3.0 is more appropriate then 2.2.1)

@nsklikas nsklikas requested a review from peppelinux September 23, 2021 07:29
@rohe rohe merged commit 9eb577b into IdentityPython:develop Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants