Skip to content
This repository was archived by the owner on Jun 23, 2023. It is now read-only.

Certification testing - bug fixes#125

Merged
rohe merged 41 commits intodevelopfrom
certification
Sep 16, 2021
Merged

Certification testing - bug fixes#125
rohe merged 41 commits intodevelopfrom
certification

Conversation

@rohe
Copy link
Collaborator

@rohe rohe commented Sep 7, 2021

Bugs/wrong behaviour found doing certification testing:

  • Client registration endpoint should return a 201 on successful client registration
  • Default token lifetime set to 30 minutes (was none)
  • Userinfo endpoint should support POST
  • Authorization error response MUST contain 'state' if present in request
  • Cookies was not picked properly - looked for wrong name.
  • Cookies was picked twice. Supposed to be only once
  • Honor max_age set in authentication request
  • invalid_grant instead of invalid_request when wrong token was used.
  • Revoke all tokens minted based on an authorization_code on seconds usage of the authorization_code.
  • Verify that the user of a token was actually the owner of the same.
  • prompt=login in authentication request SHOULD force re-authentication.

@rohe rohe requested review from nsklikas and peppelinux September 7, 2021 08:44
@rohe
Copy link
Collaborator Author

rohe commented Sep 7, 2021

I'll fix the build errors.
But not until later today. Have to do other stuff for a while.

@peppelinux
Copy link
Member

I would like to ask you to rebase all those duplicated commits, but don't worry, I won't 😸

Added tests and fixed a test result.
@rohe rohe merged commit 9a2f6cf into develop Sep 16, 2021
@peppelinux peppelinux mentioned this pull request Oct 11, 2021
@rohe rohe deleted the certification branch February 1, 2022 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants