Skip to content

Add fixes on PKCE and client_authn #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohe merged 1 commit into from
Jun 20, 2023
Merged

Add fixes on PKCE and client_authn #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/idpyoidc/server/client_authn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,10 @@ def verify_client(
if _get_client_info:
_cinfo = _get_client_info(client_id, _context)
else:
_cinfo = _context.cdb[client_id]
try:
_cinfo = _context.cdb[client_id]
except KeyError:
raise UnknownClient("Unknown Client ID")

if not _cinfo:
raise UnknownClient("Unknown Client ID")
Expand Down
3 changes: 2 additions & 1 deletion src/idpyoidc/server/oauth2/add_on/pkce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from idpyoidc.message.oauth2 import AuthorizationErrorResponse
from idpyoidc.message.oauth2 import RefreshAccessTokenRequest
from idpyoidc.message.oauth2 import TokenExchangeRequest
from idpyoidc.message.oauth2 import CCAccessTokenRequest
from idpyoidc.message.oidc import TokenErrorResponse
from idpyoidc.server.endpoint import Endpoint

Expand Down Expand Up @@ -93,7 +94,7 @@ def post_token_parse(request, client_id, context, **kwargs):
"""
if isinstance(
request,
(AuthorizationErrorResponse, RefreshAccessTokenRequest, TokenExchangeRequest),
(AuthorizationErrorResponse, RefreshAccessTokenRequest, TokenExchangeRequest, CCAccessTokenRequest),
):
return request

Expand Down