Support code_challenge_methods_supported#55
Merged
rohe merged 1 commit intoIdentityPython:developfrom Apr 9, 2023
Merged
Conversation
ctriant
force-pushed
the
oauth-discovery
branch
2 times, most recently
from
e3e3298 to
ec8a75e
Compare
Contributor
|
@ctriant please resolve conflicts and fix failing checks. |
ctriant
force-pushed
the
oauth-discovery
branch
4 times, most recently
from
b890f54 to
a987758
Compare
Signed-off-by: Kostis Triantafyllakis <kostastriantaf@gmail.com>
Contributor
Author
Contributor
|
Not sure I get what you mean with |
Contributor
Author
This dict idpy-oidc/tests/test_08_transform.py Line 44 in 24519cc |
Contributor
|
test_08_transform.py doesn't deal with add_ons so Just deal with the basic case right now. I'll tackle the add_ons. |
Contributor
Author
|
So, do you suggest any further changes? |
rohe
approved these changes
Apr 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing parameter
code_challenge_methods_supportedfor PKCE