Conversation
Contributor
Author
| request_token, grant=True | ||
| ) | ||
| except (UnknownToken, WrongTokenClass): | ||
| except (UnknownToken, WrongTokenClass, ToOld): |
Member
There was a problem hiding this comment.
This change is important to properly mark token with active: false on the introspection endpoint, when the token has expired.
Member
There was a problem hiding this comment.
(Maybe this should be split into its own PR, along with the relevant test case.)
peppelinux
reviewed
Jan 20, 2023
| request: Optional[Union[dict, Message]] = None, | ||
| authorization_token: Optional[str] = None, | ||
| endpoint=None, # Optional[Endpoint] | ||
| get_client_id_from_token=None, |
Member
There was a problem hiding this comment.
is this a pointer to a function/method?
wouldn't it be better Optional[...]?
Contributor
Author
|
I will try to break this MR into smaller ones, to facilitate the review process.
|
Contributor
Author
This was referenced Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.