Moving contest preferences from dedicated page to task list admin#1098
Conversation
anthonygego
left a comment
anthonygego
left a comment
There was a problem hiding this comment.
This is not quite the expected implementation.
There already is a dictionary for all the dispenser settings called course_structure (for legacy reasons) in task_dispenser.js that is populated by a function called dispenser_structure_<dispenser_id>. This method should be defined in a plugin-specific JS file or provided in a plugin-specific template if appropriate.
You should implement the latter method by defining a dispenser id if not defined and move the code from your dispenser_util_get_settings function into dispenser_structure_<dispenser_id>. Then adapt the check_dispenser_data method of the Contest class by moving the code from your handle_settings method.
The code in inginious/frontend/task_dispensers and inginious/frontend/pages is not expected to be changed.
|
In task_dispenser.js, is the |
Indeed, it seems it is not used anymore. |
|
LGTM. |
2 participants
This PR moves the contests settings from its dedicated page to the task list administration page. It is done in a way to allow settings to be implemented for any task dispenser.