Conversation
There was a problem hiding this comment.
Can you add a comment on how to generate this string so that people could replace it easily on setup ?
The key should also be replicated with small explanation in INGInious/docker-compose.yml
As I guess this is a mandatory parameter, we should also update the installer script to generate it appropriately in INGInious/inginious/frontend/installer.py.
anthonygego
left a comment
anthonygego
left a comment
There was a problem hiding this comment.
My comment from 2 weeks ago is still relevant.
There was a problem hiding this comment.
We should support i18n here too.
There was a problem hiding this comment.
This path needs to be updated.
There was a problem hiding this comment.
There was a problem hiding this comment.
It would be better not to hardcode the max date here, either these tests can be performed at the Python side, either date.max can be passed.
There was a problem hiding this comment.
Why don't you use the same converter ? str or, as documented, isoformat(' ') ?
There was a problem hiding this comment.
Adding a prefix to the id is a good practice.
|
There are still conflicts. According to the diff, I suspect your local branch is not correctly rebased on |
19bbf8e to
173571e
Compare
nrybowski
added
the
Feedback needed
|
I'm closing this as this set of PRs as they would need some rework and this feature is not a priority for now. |
3 participants
This PR adds a page to the course administration menu than allows admins to create and manage API tokens so that we can later use them in an API.
The purpose of this future API will be to retrieve information and statistics on student submissions.