updates to MATLAB example code - #1
Conversation
greglucas
left a comment
There was a problem hiding this comment.
I did not test the Docker container myself, so it would be good if another reviewer could do that and verify the steps/examples work as expected :) But, you did address all of my previous comments from the other repository which I think cleaned this up really nicely! Thanks for doing that.
|
I wonder if we enabled pre-commit for the entire organization instead of just per repository? I'd suggest disabling it for this repository if possible since it is just complaining that the base file isn't here, but it also doesn't make sense for this repo either... |
Changed Github Actions so it should not apply to this repo. |
|
I tried testing this out and am running into some problems: After some googling, I think this might be because I am trying this from a M1 mac? Perhaps someone without an M1 can try this out? Otherwise, the image seems to build just fine. |
|
@bourque, that error looks like it is searching for some x86 system libraries, so I'd agree with your assessment about the M1 mac. Are you able to build with I did verify that this works for me locally on an intel-based mac. |
|
Same error as Matthew. I tried with platform argument and that seems to work now. |
We should add that into the documentation somehow because I'm sure others using this will run into the same issue. |
Co-authored-by: Maxine Hartnett <117409426+maxinelasp@users.noreply.github.com>
Co-authored-by: Maxine Hartnett <117409426+maxinelasp@users.noreply.github.com>
|
Responded to all comments. Thanks for those! |
No description provided.