Skip to content

updates to MATLAB example code - #1

Merged
laspsandoval merged 7 commits into
IMAP-Science-Operations-Center:devfrom
laspsandoval:main
Jul 17, 2023
Merged

updates to MATLAB example code#1
laspsandoval merged 7 commits into
IMAP-Science-Operations-Center:devfrom
laspsandoval:main

Conversation

@laspsandoval

Copy link
Copy Markdown
Contributor

No description provided.

@greglucas greglucas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test the Docker container myself, so it would be good if another reviewer could do that and verify the steps/examples work as expected :) But, you did address all of my previous comments from the other repository which I think cleaned this up really nicely! Thanks for doing that.

@greglucas

Copy link
Copy Markdown

I wonder if we enabled pre-commit for the entire organization instead of just per repository? I'd suggest disabling it for this repository if possible since it is just complaining that the base file isn't here, but it also doesn't make sense for this repo either...

@laspsandoval

laspsandoval commented Jul 2, 2023

Copy link
Copy Markdown
Contributor Author

I wonder if we enabled pre-commit for the entire organization instead of just per repository? I'd suggest disabling it for this repository if possible since it is just complaining that the base file isn't here, but it also doesn't make sense for this repo either...

Changed Github Actions so it should not apply to this repo.

@bourque

bourque commented Jul 5, 2023

Copy link
Copy Markdown

I tried testing this out and am running into some problems:

mabo8927: docker run --rm -it -e PROCESSING_DROPBOX=/opt/data/dropbox/ --volume="$(pwd)/container_example_data:/opt/data" matlab-image:latest "algorithm_example /opt/data/dropbox/input_manifest_20220923t000000.json"
MATLAB is selecting SOFTWARE OPENGL rendering.
Fatal Startup Error: 
Throw location unknown (consider using BOOST_THROW_EXCEPTION)
Dynamic exception type: foundation::core::except::detail::AnonymousInternalException<mwboost::system::system_error>
std::exception::what: uint64_t foundation::core::system::linux::x86_64::getMaximumProcessorFrequencyImpl(): Numerical result out of range
[(anonymous namespace)::narrow_str_tag*] = uint64_t foundation::core::system::linux::x86_64::getMaximumProcessorFrequencyImpl(): Numerical result out of range

After some googling, I think this might be because I am trying this from a M1 mac? Perhaps someone without an M1 can try this out?

Otherwise, the image seems to build just fine.

@greglucas

Copy link
Copy Markdown

@bourque, that error looks like it is searching for some x86 system libraries, so I'd agree with your assessment about the M1 mac. Are you able to build with docker build --platform linux/amd64 ...? I'm wondering if you built the container for x86, but are trying to run it on amd64. I have no idea if Matlab will even build that way though, and I don't have an M1 to try it out. https://docs.docker.com/build/building/multi-platform/

I did verify that this works for me locally on an intel-based mac.

@tech3371

Copy link
Copy Markdown

Same error as Matthew. I tried with platform argument and that seems to work now.

Comment thread docs/docker.md
@greglucas

Copy link
Copy Markdown

Same error as Matthew. I tried with platform argument and that seems to work now.

We should add that into the documentation somehow because I'm sure others using this will run into the same issue.

Comment thread docs/docker.md Outdated
Comment thread docs/docker.md Outdated
laspsandoval and others added 3 commits July 17, 2023 10:04
Co-authored-by: Maxine Hartnett <117409426+maxinelasp@users.noreply.github.com>
Co-authored-by: Maxine Hartnett <117409426+maxinelasp@users.noreply.github.com>
@laspsandoval

Copy link
Copy Markdown
Contributor Author

Responded to all comments. Thanks for those!

@laspsandoval laspsandoval reopened this Jul 17, 2023
@laspsandoval
laspsandoval merged commit 2354673 into IMAP-Science-Operations-Center:dev Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants