NM #608
Merged
NM #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heuristic to avoid thread binding if less than 8 threads are requested resulted in the first 7 threads not being bound. The branch was verified to yield a roughly 13% speedup by @CoffeeOne on the appropriate hardware and OS, and an earlier version of this patch tested well on his machine: http://tests.stockfishchess.org/tests/view/5a3693480ebc590ccbb8be5a ELO: 9.24 +-4.6 (95%) LOS: 100.0% Total: 5000 W: 634 L: 501 D: 3865 To make sure all threads (including mainThread) are bound as soon as the total number exceeds 7, recreate all threads on a change of thread number. To do this, unify Threads::init, Threads::exit and Threads::set are unified in a single Threads::set function that goes through the needed steps. The code includes several suggestions from @joergoster. Fixes issue #1312 No functional change
When calculating attacks from rooks/bishops current master includes x-rays through own queen. This patch includes also x-rays through opponent queen. Credits go to Brian who inspired for this idea https://groups.google.com/forum/?fromgroups=#!topic/fishcooking/Z3APRYpQeMU STC: LLR: 2.96 (-2.94,2.94) [0.00,5.00] Total: 41549 W: 7544 L: 7244 D: 26761 Elo 2.05 [-0.29,4.19] (95%) http://tests.stockfishchess.org/tests/view/5a3b5fe50ebc590ccbb8bf9a LTC: LLR: 2.96 (-2.94,2.94) [0.00,5.00] Total: 110010 W: 14208 L: 13739 D: 82063 Elo 1.20 [-0.27,2.55] (95%) http://tests.stockfishchess.org/tests/view/5a3b8e7c0ebc590ccbb8bfad bench: 5544445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.