On call improvements to admin #280
Conversation
| <form id="createClientForm"> | ||
| <div class="card card-body"> | ||
| <div class="form-group"> | ||
| <h5>Create a new client</h5> |
There was a problem hiding this comment.
Suggestion: "Create a new client key"
…IABTechLab/uid2-admin into tjm-UID2-3488-oncall-improvements-admin
| <input type="checkbox" id="createClient-workflow-roles-MAPPER" | ||
| class="form-check-input" name="createClient-workflow-roles[]" | ||
| value="MAPPER"> | ||
| <label for="createClient-workflow-roles-GENERATOR">MAPPER - for |
There was a problem hiding this comment.
I think we need to change GENERATOR to MAPPER here: createClient-workflow-roles-MAPPER
| <table class="table table-bordered" id="searchResultsTable"> | ||
| <thead> | ||
| <th scope="col" class="col-1">Sites</th> | ||
| <th scope="col" class="col-1">Clients</th> |
There was a problem hiding this comment.
I think this should be "Client Keys" or "API Keys"
There was a problem hiding this comment.
In the Portal and our external docs, we call them "API Keys". I think consistency would be good
| <div class="row"> | ||
| <div class="col"> | ||
| <ol> | ||
| <li>First seach for a participant with the requested name from the Jira ticket.</li> |
There was a problem hiding this comment.
Similar to the other file, would suggest: "Search for a participant with the requested name from the Jira ticket"
webroot/index.html
Outdated
| <br> | ||
| </div> | ||
|
|
||
| <h3>On-call Support Workflow</h3> |
There was a problem hiding this comment.
This can be hidden before logged in like other rows
Fixed some bugs Addressed review comments
…IABTechLab/uid2-admin into tjm-UID2-3488-oncall-improvements-admin
| id="createSite-workflow-clientTypes-PUBLISHER" | ||
| class="form-check-input" | ||
| name="createSite-workflow-clientTypes[]" value="PUBLISHER"> | ||
| <label for="createSite-workflow-clientTypes-PUBLISHER">Is this |
There was a problem hiding this comment.
nit: could we please put this string on one line? I was trying to search for it but was proving difficult to find.
There was a problem hiding this comment.
I'm also not sure exactly how accurate this statement is - I believe advertisers can use it too.
There was a problem hiding this comment.
That's correct. Btw please see our CSTG How-to page as advertisers should generally go via the portal rather than us doing it in Admin.
| <button type="button" aria-controls="createSiteRegion" aria-expanded="false" | ||
| id="createSite" data-bs-parent="#siteParent" class="btn btn-secondary group" | ||
| data-bs-toggle="collapse" data-bs-target="#createSiteRegion" | ||
| role="button">Create site</button> |
There was a problem hiding this comment.
nit: <button> already as the implicit role of "button", so we don't need to specify it explicitly. There's a few instances in this file and in generate-api-key-secrets.html
Fixed bugs
…IABTechLab/uid2-admin into tjm-UID2-3488-oncall-improvements-admin
| name="updateSite-workflow-afterSearch-clientTypes[]" | ||
| value="PUBLISHER"> | ||
| <label for="updateSite-workflow-afterSearch-PUBLISHER">Is this participant a publisher? Only publishers are allowed to use CSTG. </label> | ||
| <div>If the participant is an Advertiser, check <a href="https://atlassian.thetradedesk.com/confluence/display/UID2/UID2+CSTG+How+to+create+a+new+client+side+keypair" target="_blank">UID2 CSTG How to create a new client side keypair</a> for details</div> |
There was a problem hiding this comment.
Should we also have this when creating a new site?
4 participants
Tested in Integ via a branch deploy.
The Bootstrap files added were directly from Bootstrap distribution