UID2-1983 ensure first key in a keyset is immediately active#278
Merged
UID2-1983 ensure first key in a keyset is immediately active#278
Conversation
| } | ||
|
|
||
| @Test | ||
| void whenAddSecondKeyForKeysetItIsNotImmediatelyActive() throws Exception { |
Contributor
There was a problem hiding this comment.
Nit pick, do we want to have one test case that when isDuringRotation is true?
Contributor
Author
There was a problem hiding this comment.
There are lots of existing rotation checks below. These call checkRotatedKeyResponse which ensures activates has the correct timestamp.
Contributor
|
LGTM. |
caroline-ttd
approved these changes
May 30, 2024
sunnywu
reviewed
May 31, 2024
| setKeysetKeys(MAX_KEY_ID, keys); | ||
|
|
||
| final KeysetKey key2 = keyService.addKeysetKey(keysetId); | ||
| assertTrue(key2.getActivates().isAfter(key2.getCreated())); |
Contributor
There was a problem hiding this comment.
should we check if activates is after created but within certain expected time limit?
Contributor
Author
There was a problem hiding this comment.
I fixed the test to be more specific
sunnywu
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.