update top level domain function to collect list of top level domains#273
Merged
ashleysmithTTD merged 4 commits intomainfrom May 15, 2024
Merged
Conversation
Contributor
cody-constine-ttd
left a comment
cody-constine-ttd
left a comment
There was a problem hiding this comment.
Can we add a test that submits multiple invalid domains.
| } | ||
|
|
||
| if (!invalidDomainNames.isEmpty()) { | ||
| ResponseUtil.error(rc, 400, invalidDomainNames.toString()); |
Contributor
There was a problem hiding this comment.
Can you keeps some info in here like "Invalid domains: "
cody-constine-ttd
approved these changes
May 14, 2024
ashleysmithTTD
deleted the
ans-UID2-3321-return-invalid-domains-from-admin
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.