Adding the ability to rename sites#270
Merged
cody-constine-ttd merged 3 commits intomainfrom May 6, 2024
Merged
Conversation
cYKatherine
reviewed
Apr 29, 2024
cYKatherine
reviewed
Apr 29, 2024
thomasm-ttd
reviewed
Apr 29, 2024
thomasm-ttd
reviewed
Apr 29, 2024
thomasm-ttd
reviewed
Apr 30, 2024
| } | ||
| } | ||
| if (name != null) { | ||
| if (validateSiteName(rc, name)) return; |
Contributor
There was a problem hiding this comment.
It appears the convention in this file (which I also prefer) is that if statements have a following brace:
if (validateSitenName(rc, name)) {
return;
}
alex-yau-ttd
reviewed
May 1, 2024
| .stream().filter(c -> c.getName().equals(name)) | ||
| .findFirst(); | ||
| if (existingSite.isPresent()) { | ||
| ResponseUtil.error(rc, 400, "site existed"); |
Contributor
There was a problem hiding this comment.
nit: not that the code is new, but could we possibly align on some improved language and do something like we do in ServiceService.java
So:
ResponseUtil.error(rc, 400, "site with name" + name + " already exists");
alex-yau-ttd
reviewed
May 1, 2024
| }; | ||
| setSites(sites); | ||
|
|
||
| post(vertx, testContext, "api/site/update?id=11&name=site2", null, response -> { |
Contributor
There was a problem hiding this comment.
nit: I think extracting this case to a separate test renameSiteTestDuplicateName would help with readability
thomasm-ttd
approved these changes
May 1, 2024
alex-yau-ttd
approved these changes
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Rename:
After Rename: