Add if-else statement and ternary operator #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlioshaRabeshko
changed the title
tshemsedinov
requested changes
Oct 3, 2017
Member
tshemsedinov
left a comment
tshemsedinov
left a comment
There was a problem hiding this comment.
- Remove
.eslintrc.ymlfrom rull-request because of merge conflict - Use eslint before comit
- After that you need to rebase with master, I'll help
JavaScript/5-if-else.js
Outdated
| @@ -0,0 +1,45 @@ | |||
| 'use strict'; | |||
|
|
|||
|
|
|||
Member
There was a problem hiding this comment.
Use single empty line to separate logical blocks
JavaScript/5-if-else.js
Outdated
| } | ||
|
|
||
| if (condition2) | ||
| console.log('5 > 3'); |
Member
There was a problem hiding this comment.
or remove \n to have single line condition
tshemsedinov
reviewed
Oct 8, 2017
| } | ||
| // Good syntax | ||
| condition2 ? console.log('5 > 3') : console.log(false); | ||
| // Good syntax |
tshemsedinov
approved these changes
Oct 8, 2017
Member
tshemsedinov
left a comment
tshemsedinov
left a comment
There was a problem hiding this comment.
Remove lines and file .gitignore, everything else is ok
| const condition2 = 5 > 3; // Boolean true | ||
| const name = 'Ryu'; // String | ||
|
|
||
| // Good syntax |
| if (condition1) { | ||
| console.log('5 < 3'); | ||
| } | ||
| // Good syntax |
tshemsedinov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.