Skip to content

Improve data structures and implementation#4

Open
tshemsedinov wants to merge 1 commit into
unitsfrom
units-alternative
Open

Improve data structures and implementation#4
tshemsedinov wants to merge 1 commit into
unitsfrom
units-alternative

Conversation

@tshemsedinov

Copy link
Copy Markdown
Member

No description provided.

@tshemsedinov tshemsedinov added the enhancement New feature or request label Oct 22, 2019
@tshemsedinov tshemsedinov self-assigned this Oct 22, 2019
@HowProgrammingWorks HowProgrammingWorks locked and limited conversation to collaborators Oct 22, 2019
Comment thread JavaScript/3-units.js
hours: { rx: /(\d+)\s*h/, mul: 3600 },
minutes: { rx: /(\d+)\s*m/, mul: 60 },
seconds: { rx: /(\d+)\s*s/, mul: 1 }
d: 86400, // days

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
d: 86400, // days
d: 24 * 60 * 60, // days

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants