Improve between implementation#3
Open
tshemsedinov wants to merge 1 commit into
Open
Conversation
nechaido
reviewed
Oct 22, 2019
| i = line.indexOf(end); | ||
| if (i === -1) return ''; | ||
| str = str.substring(0, i); | ||
| return line.substring(0, i); |
Member
There was a problem hiding this comment.
I'd prefer to implement this function in a way, that we only create a substring once in each case.
Current implementation extracts substring twice if we provide end quote.
tshemsedinov
commented
Oct 22, 2019
| @@ -3,13 +3,15 @@ | |||
| // Implementation | |||
|
|
|||
| const between = (str, quotes) => { | |||
Member
Author
There was a problem hiding this comment.
Looks like we can make in more flexible
Suggested change
| const between = (str, quotes) => { | |
| const between = (str, start, end) => { |
| if (quotes[1]) { | ||
| i = str.indexOf(quotes[1]); | ||
| const line = str.substring(i + 1); | ||
| if (end) { |
Member
Author
There was a problem hiding this comment.
We expect than end argument always present, so if is not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.