Fixed danmar#7405 (false positive: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.)

danmar · danmar · commit e5e6f37e416d · 2017-09-05T22:03:29.000+02:00
diff --git a/lib/checkcondition.cpp b/lib/checkcondition.cpp
@@ -593,6 +593,13 @@ void CheckCondition::multiCondition2()
                 (!tok->varId() && nonlocal)) {
                 if (Token::Match(tok, "%name% %assign%|++|--"))
                     break;
+                if (Token::Match(tok->astParent(), "*|.|[")) {
+                    const Token *parent = tok;
+                    while (Token::Match(parent->astParent(), ".|[") || (Token::simpleMatch(parent->astParent(), "*") && !parent->astParent()->astOperand2()))
+                        parent = parent->astParent();
+                    if (Token::Match(parent->astParent(), "%assign%"))
+                        break;
+                }
                 if (Token::Match(tok, "%name% <<|>>") && (!tok->valueType() || !tok->valueType()->isIntegral()))
                     break;
                 if (Token::Match(tok, "%name% [")) {
diff --git a/test/testcondition.cpp b/test/testcondition.cpp
@@ -1522,6 +1522,13 @@ class TestCondition : public TestFixture {
               "}");
         ASSERT_EQUALS("", errout.str());
 
+        check("void test(float *f) {\n" // #7405
+              "  if(*f>10) {\n"
+              "    (*f) += 0.1f;\n"
+              "    if(*f<10) {}\n"
+              "  }\n"
+              "}");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void oppositeInnerConditionClass() {
