feat(engine): inbox basics — saved replies & macros, snooze, send & close (HT-76/77/78) - #90

src/api/conversations.ts (1)

874-898: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value

snoozedUntil validation accepts non-ISO-8601 strings.

new Date(snoozedUntil) is more permissive than the documented "ISO-8601 timestamp" contract (spec §4b) — it also accepts many non-ISO formats, and JS date-string parsing for non-standard formats isn't fully engine-consistent. Consider a stricter check (e.g. an ISO-8601 regex guard before new Date(...)) if malformed-but-parseable inputs should be rejected per the documented contract.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/api/conversations.ts` around lines 874 - 898, Strengthen snoozedUntil
validation in parsePatchStatusBody by requiring the string to match the
documented ISO-8601 timestamp format before constructing a Date, while retaining
the existing pending-status requirement and invalid-date rejection.

src/mail/snooze-wake.ts (1)

62-78: 🚀 Performance & Scalability | 🔵 Trivial | 💤 Low value

Consider bounded concurrency for the wake-pass loop.

Each setConversationStatus call operates on an independent row, so sequentially awaiting all dueIds (up to DEFAULT_BATCH_SIZE = 100) serializes round-trips that could run concurrently (e.g. Promise.all with a concurrency cap) to reduce one pass's wall-clock time, without changing per-row correctness or event semantics.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/mail/snooze-wake.ts` around lines 62 - 78, The runSnoozeWake loop
currently awaits each setConversationStatus call sequentially; update it to
process independent dueIds with bounded concurrency, preserving the
requireStatus condition, woken count, report values, and per-row event behavior.
Use an appropriate concurrency cap rather than unbounded Promise.all.

src/db/migrate.ts (1)

1347-1352: 🚀 Performance & Scalability | 🔵 Trivial

Consider a partial index to support the every-minute due-snooze scan.

The snooze-wake cron runs listDueSnoozed (src/store/conversations.ts) every minute, filtering status = 'pending' AND snoozed_until IS NOT NULL AND snoozed_until <= now() ordered by snoozed_until. Migration 025 adds only the column and CHECK, so this query has no supporting index and degrades to a sequential scan as conversations grows. A small partial index keeps the scan bounded to actually-snoozed rows.

⚡ Optional partial index for the due-snooze query

 ALTER TABLE conversations ADD COLUMN snoozed_until timestamptz;
 ALTER TABLE conversations ADD CONSTRAINT conversations_snoozed_until_pending_only CHECK (
   snoozed_until IS NULL OR status = 'pending'
 );
+CREATE INDEX conversations_snoozed_until_idx
+  ON conversations (snoozed_until)
+  WHERE snoozed_until IS NOT NULL;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/db/migrate.ts` around lines 1347 - 1352, Update
MIGRATION_025_CONVERSATION_SNOOZE to add a partial index on
conversations.snoozed_until for rows where status = 'pending' and snoozed_until
IS NOT NULL, supporting the filtering and ordering performed by listDueSnoozed.