docs(charter): marketplace becomes a launch-day component of Phase 3 (HT-79) - #86
Merged
Conversation
…(HT-79) TJ's call (2026-07-19): 'later' is now. §3/§4/§5 amended with a dated, reasoned note in the established tradition — deferral rationale obsolete (substrate + first modules shipped during dogfood), license stays a distribution credential (no runtime checks, catalog §5), §7-exception deadline unchanged (v1 modules are all out-of-process), counsel gains commercial-license + terms-of-sale items before real money. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughCHARTER.md updates the paid-module strategy, makes the marketplace a Phase 3 day-one component, identifies initial paid modules, and adds governance and counsel requirements for commercial launch. ChangesMarketplace rollout
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHARTER.md`:
- Line 45: Update the build-time extension terminology in the paragraph to call
these artifacts “npm Modules” instead of “npm plugins,” while preserving the
surrounding meaning and capitalization. Do not alter permitted legal terminology
such as “plugin exception” if it appears elsewhere.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
CodeRabbit caught the pre-existing 'build-time npm plugins' phrase in the paragraph this amendment touches — the vocabulary rule reserves 'plugin' for the legal phrase; swept while amending. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
zaridan
added a commit
that referenced
this pull request
Jul 19, 2026
…sics (#91) PR #83 landed already-stale: main moved by nine PRs while it was in review, and it shipped one claim that contradicts the charter. - HT-71 operator guide was listed as an open PR under Next. #81 merged at 17:48, ~2h before #83 merged at 19:39, and docs/modules/ has been on main since. Moved to Done with its precision follow-up (#84). - Marketplace was listed under 'Not yet / deferred'. CHARTER §3/§4/§5 were amended the same day (HT-79, #86) to make it a launch-day component of Phase 3 — built now, proven as the dogfood install path. Removed from deferred; marketplace v1 spec (#87, draft) now leads Next. - Added inbox basics (HT-76/77/78, #90, migrations 24-25): saved replies & macros, snooze, send & close — shipped engine features with no STATUS line. - Added catalog reclassification (HT-75, #82): KB and end-user portal are paid, 71-module gap audit closed, open-core line restated. Passkeys stay core, reconciled in #85. - Added passkey login spec (HT-75, specs/auth/passkeys.md, draft.3) to Next. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
zaridan
added a commit
that referenced
this pull request
Jul 19, 2026
…harter (HT-79) (#92) The HT-79 charter amendment merged as PR #86 (b528971), discharging the spec's sequencing note, which asked for a citation re-check against the merged text before acceptance. All CHARTER.md citations re-verified against merged §3/§4/§5: the launch-day Phase 3 claim, the marks-and-marketplace asset list, the amendment's verbatim counsel-items sentence, and the Phase 3 launch lineup all check out as written. One mis-citation corrected: the plugin exception's counsel deadline was attributed to "CHARTER.md §7," but CHARTER.md §7 is Governance — the deadline is set in §3's module boundary, where "§7" names the AGPL-3.0 §7 additional permission. Its parenthetical pointing at "this spec's §3" was dangling for the same reason. Replaced with a direct quote of the merged amendment. Docs-only; no substantive change. Status stays "draft for TJ review". Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
zaridan
added a commit
that referenced
this pull request
Jul 20, 2026
…e install path (HT-79) (#98) * docs(modules): managed hosting becomes the mainline install path (HT-79) TJ walked the v1 manual self-host install as customer #1 (HT-82 dogfood) and rejected its friction: the designed loop is browse → buy → install → enable, not five hand-assembled seams. This revises marketplace-v1 to v1.1 with managed hosting as the default, the tarball flow demoted to a preserved self-host escape hatch. - specs/modules/marketplace-v1.md → v1.1: new hosting control plane (§3d, the sole trust domain holding both a license key and a per-desk provisioning grant, entirely outside the AGPL core); the buy → install → enable managed handoff via a one-time claim token redeemed by the control plane, never the desk (§3e); rewritten §5 (managed install/update/ uninstall mainline + self-host escape hatch §5.4); one-click in-place update for hosted instances, resolving the admin-ia "in-place update" conflict; hosted-instance lifecycle (lapsed/frozen keep running, refunded decommissions after a config-export grace, revoked immediately); §6/§7/§8/ §9/§10 updated. Entities, commerce/download/update-check APIs, and the artifact pipeline are unchanged. - CHARTER.md: amended by direct edit (§4 + §7 appendix, the PR #86 mechanism) — restates the credential/no-runtime-check/lapse invariants for managed hosting; leaves the §2 data-residency reconciliation to TJ. - specs/modules/catalog.md: §5 reconciling note (hosting machinery lives outside the core, so "no special machinery in the product" still holds). - SPEC-CHANGES.md: chosen-defaults and OPEN-needs-TJ lists for the lead. Invariants held verbatim: license = distribution credential only, zero runtime license checks in any module, lapse never stops running software (even when RIQ is the host), AGPL core never holds a marketplace credential and never calls the marketplace. Self-host escape hatch preserved and not weakened. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(modules): collect module runtime config browser-direct to the control plane (lead review fix) Lead-tier review finding on the managed-hosting revision: §5.1 promised 'no hand-entered env vars' but never said where operator-supplied module settings — most prominently the operator's own model API key, which charter §2 requires — come from in the managed flow. Added §3e 'Module runtime configuration': an install-time in-app form submitted browser-direct to the control plane (same never-transits-the-core rule as the claim token), stored in the control-plane vault, re-injected on update rolls; §5.1 reworded honestly; §10.13 extended — operator secrets in the vault are the credential face of the same data-residency call. Also drops SPEC-CHANGES.md from the branch: it is adjudication material for the PR description, not a permanent repo artifact. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the maintainer's decision (2026-07-19): the marketplace goes live WITH the public launch, not after — built now, tested as our own dogfood install path (HT-79–HT-82).
Charter §3/§4/§5 amended in the established dated-amendment tradition: the 'later phase / once demand justifies it' deferral is retired with its rationale stated (the substrate and first modules already exist, so what remains is commerce plumbing, not speculation); the license-as-distribution-credential posture (zero runtime checks) is now charter-level language; the §7 plugin-exception counsel deadline is explicitly UNCHANGED (all v1 marketplace modules are out-of-process — no exception needed); counsel scope gains the commercial module license text and terms of sale as pre-revenue gates.
Docs-only.
🤖 Generated with Claude Code
Summary by CodeRabbit