Skip to content

fix(web): declare @types/node so web/ builds standalone (HT-23) - #64

Merged
zaridan merged 1 commit into
mainfrom
fix/ht-23-web-standalone-types
Jul 17, 2026
Merged

fix(web): declare @types/node so web/ builds standalone (HT-23)#64
zaridan merged 1 commit into
mainfrom
fix/ht-23-web-standalone-types

Conversation

@zaridan

@zaridan zaridan commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

One-liner: the new helpthread-inbox Vercel project roots at web/, where hoisted root devDeps are invisible — Next's production type-check failed with "install @types/node" (deployment dpl_9fkhbkz). Declares @types/node in web/package.json; monorepo installs dedupe to the root copy unchanged.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added Node.js type definitions to improve development tooling and type support.

The helpthread-inbox Vercel project deploys web/ as its own root, so
hoisted root-workspace devDependencies are invisible there. Next's
production type-check needs @types/node present in web/package.json
itself. Monorepo installs are unaffected (npm dedupes to the root).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ca2c578d-b55b-48c8-a2e2-73d96fdbf520

📥 Commits

Reviewing files that changed from the base of the PR and between efc015c and 710c22e.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • web/package.json

📝 Walkthrough

Walkthrough

The web package development dependencies now include @types/node version ^20.19.43.

Changes

Node.js type dependency

Layer / File(s) Summary
Add Node.js type declarations
web/package.json
Adds @types/node to devDependencies at version ^20.19.43.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes adding @types/node to web/package.json to support standalone web builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ht-23-web-standalone-types

Comment @coderabbitai help to get the list of available commands.

@zaridan
zaridan merged commit ea0de81 into main Jul 17, 2026
5 checks passed
@zaridan
zaridan deleted the fix/ht-23-web-standalone-types branch August 2, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant