Skip to content

fix(ci): let the verdict line carry a trailing clause (HT-100) #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zaridan merged 2 commits into from
Aug 8, 2026
Merged

fix(ci): let the verdict line carry a trailing clause (HT-100) #202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
368c4d3
fix(ci): let the verdict line carry a trailing clause (HT-100)
zaridan Aug 7, 2026
4d1a0e8
fix(ci): reject a green verdict whose first line is itself marked INF…
zaridan Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions .github/workflows/pr-verdict.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,21 @@ jobs:
# line. Matching anywhere would let a PR bury the verdict under arbitrary
# prose — the whole point is that it is the first thing read.
#
# The whole line must BE the verdict, not merely contain it: leading `#`s
# and the emoji are allowed (`## 🟢 SAFE TO MERGE`), but trailing words are
# not, so `Status: SAFE TO MERGE pending review` is rejected. `[^[:alnum:]]*`
# covers the emoji without this file having to carry a Unicode class.
# The line must OPEN with the verdict: leading `#`s and the emoji are
# allowed (`## 🟢 SAFE TO MERGE`), and a trailing clause is allowed
# (`## 🔴 DO NOT MERGE — review and CI pending`), but nothing may precede
# it. That rejects `Status: SAFE TO MERGE pending review`, where the verdict
# is buried and qualified, while leaving the ordinary habit of appending a
# reason alone — a gate that fails honest bodies teaches people to paste
# ceremony, which is the exact habit this exists to break.
# `[^[:alnum:]]*` covers the emoji without this file having to carry a
# Unicode class.
#
# VERDICT is captured here and reused by check 5, so a body that merely
# *mentions* another verdict cannot change how it is validated.
FIRST_LINE=$(grep -m1 -vE '^[[:space:]]*$' <<<"$BODY" || true)
verdict_is() {
grep -qE "^#{0,6}[[:space:]]*[^[:alnum:]]*[[:space:]]*$1[[:space:]]*$" <<<"$FIRST_LINE"
grep -qE "^#{0,6}[[:space:]]*[^[:alnum:]]*[[:space:]]*$1([[:space:]]|$)" <<<"$FIRST_LINE"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
VERDICT=""
if verdict_is 'SAFE TO MERGE'; then VERDICT=safe
Expand All @@ -127,6 +132,25 @@ jobs:
fail "The PR body's first line must be exactly the verdict, on its own: 🟢 SAFE TO MERGE / 🟡 NEEDS YOUR DECISION / 🔴 DO NOT MERGE. Found: ${FIRST_LINE:0:80}"
fi

# 1b. A green verdict cannot itself carry an INFERRED token in the trailing
# clause this PR just started allowing — e.g. "SAFE TO MERGE — INFERRED"
# — because check 3 below only reads INFERRED out of provenance-table
# rows, never out of the verdict line. The protocol already forbids the
# combination ("If there is at least one INFERRED item, the verdict is
# 🟡. Never 🟢"), so this fails rather than silently downgrading the
# author's stated verdict.
#
# Matched case-SENSITIVELY on the literal token INFERRED, unlike check 3.
# The protocol's own examples always write the marker in caps; matching
# case-insensitively here would fail an honest clause like "no inferred
# items" for using the plain word, reintroducing the failure mode this
# PR exists to fix. A provenance row still catches "inferred" in any case
# via check 3, unchanged.
if [ "$VERDICT" = safe ] \
&& grep -qE '(^|[^[:alnum:]])INFERRED([^[:alnum:]]|$)' <<<"$FIRST_LINE"; then
fail "Verdict is SAFE TO MERGE but the opening line itself is marked INFERRED: ${FIRST_LINE:0:80}"
fi

# 2. A decision-provenance section.
# Anchored: "## Decision provenance deliberately omitted" is a heading that
# says the opposite of what it would otherwise satisfy.
Expand Down
Loading