Fix version.rc build failures in Delphi 12.1 #2164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Make version.rc compile successfully under Delphi 12.1 Previously, version.rc failed to compile due to missing macro definitions like VOS__WINDOWS32. This update adds `#include <winver.h>` and fills out standard VERSIONINFO fields, restoring compatibility with the Delphi 12.1 resource compiler. - Resolves RC2104 (undefined keyword) and RC1015 (missing include) - Retains %APPNAME% and %APPVER% placeholders for Delphi substitutions - No changes to build behavior — just unblocks successful compilation Tested with Delphi 12.1 CE (`rc.exe`) and Microsoft Windows SDK resource compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Make version.rc compile successfully under Delphi 12.1
Previously, version.rc failed to compile due to missing macro definitions like VOS__WINDOWS32. This update adds
#include <winver.h>and fills out standard VERSIONINFO fields, restoring compatibility with the Delphi 12.1 resource compiler.Tested with Delphi 12.1 CE (
rc.exe) and Microsoft Windows SDK resource compiler.