Updates AST break and continue visitors to warn about labeled constructs.

Troy Melhase · Troy Melhase · commit 00278237d2d4 · 2012-02-04T19:56:41.000-05:00
diff --git a/doc/features.md b/doc/features.md
@@ -136,11 +136,11 @@ Java `return` statements are translated to equivalent Python `return` statements
 Java `throw` statements are translated to equivalent Python `throw` statements.
 
 ##### break
-Java `break` statements are translated to equivalent Python `break` statements.  However, a Java `break` statement with an identifier (e.g., `break FOO`) is not supported.  If the compiler detects such a statement, a waring will be printed and the translated source will not
+Java `break` statements are translated to equivalent Python `break` statements.  However, a Java `break` statement with an identifier (e.g., `break FOO`) is not supported.  If the compiler detects such a statement, a warning will be printed and the translated source will not
 contain the original label.
 
 ###### continue
-Java `continue` statements are translated to equivalent Python `continue` statements.  However, a Java `continue` statement with an identifier (e.g., `continue FOO`) is not supported.  If the compiler detects such a statement, a waring will be printed and the translated source will not
+Java `continue` statements are translated to equivalent Python `continue` statements.  However, a Java `continue` statement with an identifier (e.g., `continue FOO`) is not supported.  If the compiler detects such a statement, a warning will be printed and the translated source will not
 contain the original label.
 
 
diff --git a/java2python/compiler/visitor.py b/java2python/compiler/visitor.py
@@ -14,7 +14,7 @@
 
 from functools import reduce, partial
 from itertools import ifilter, ifilterfalse, izip, tee
-from logging import debug
+from logging import debug, warn
 from re import compile as recompile, sub as resub
 
 from java2python.lang import tokens
@@ -370,6 +370,8 @@ def acceptBreak(self, node, memo):
             if parent.type in ok_types:
                 break
         if insert:
+            if len(node.children):
+                warn('Detected unhandled break statement with label; generated code incorrect.')
             breakStat = self.factory.statement('break', parent=self)
 
     def acceptCatch(self, node, memo):
@@ -390,6 +392,8 @@ def acceptCatch(self, node, memo):
     def acceptContinue(self, node, memo):
         """ Accept and process a continue statement. """
         contStat = self.factory.statement('continue', fs=FS.lsr, parent=self)
+        if len(node.children):
+            warn('Detected unhandled continue statement with label; generated code incorrect.')
 
     def acceptDo(self, node, memo):
         """ Accept and process a do-while block. """
