Neon support#169
Merged
Merged
Conversation
vld can de-interleave up to 4-float element structures in one go into multiple registers. This allows us to load each column of the matrix and put each element into a corresponding vector, essentially doing the entire transpose in 1 instruction Fixed it
bvisness
requested changes
Dec 12, 2023
bvisness
left a comment
bvisness
left a comment
Member
There was a problem hiding this comment.
Looks great in general. Just left a general note about why we were so verbose with some operations. Thank you so much for submitting this!
bvisness
approved these changes
Dec 16, 2023
bvisness
left a comment
bvisness
left a comment
Member
There was a problem hiding this comment.
Wonderful! Thank you so much!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like support for neon was talked about a while ago in #79. So thought I'd try tackling it, I've tried to remain as close to the existing style as possible. I'm no floating point expert but after reading #152 I've tried to be as consistent with the existing implementation as possible but I may have made some mistakes in that regard.