Skip to content

HMM_LinearCombineV4M4 has incorrect name and naming of arguments #160

Description

@EeroMutka

HMM_LinearCombineV4M4 internally does a matrix4 * vector4 operation. HMM_MulM4V4 even directly calls it to perform this exact operation. The arguments to HMM_LinearCombineV4M4 however have incorrect names making it seem like it does the opposite:

HMM_Vec4 HMM_LinearCombineV4M4(HMM_Vec4 Left, HMM_Mat4 Right)

It should look instead like:

HMM_LinearCombineM4V4(HMM_Mat4 Left, HMM_Vec4 Right)

"Matrix multiplication is computed as follows: let the matrix C be the r×c product AB of the
r×n matrix A with the n×c matrix B. Then each element cij is equal to the vector dot product of row
i of A with column j of B", from 3D Math Primer for Graphics and Game Development (F. Dunn, I. Parberry)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions