Merged
Conversation
oformaniuk
approved these changes
Mar 26, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Includes:
First time contributing, my fix is to remove the following
ifcheck in order to return a normalObjectDescriptorwithin theObjectDescriptorProvider.TryGetDescriptor(...)method.I don't fully understand the reasoning behind this
ifcheck.This
ifcheck was added in "Introduce reactive helper registration, improve general performance" - commit: 9d52004.Anyway this PR removes this check, let me know if you don't think this is a good change or have any suggestions.