Last letter cut off when the string starts with the separator#504
Conversation
|
Thanks for the contribution! Since this bug slipped in without failing any unit tests, can you please add at least 1 so we can guarantee it never happens again? |
|
Sure thing! |
|
So, I was writing some tests and I noticed something, and I am not sure if it is intended or a side-effect of my change. Update: I looked it up and it looks like the default String.Split() method has a similar behaviour. |
|
If you revert your change does it still happen? |
|
You are right. It does. |
|
Everything seems to be working on my machine and the new test covers the previous issue with the sub-strings. |
|
@periklis92 , the problem looks to be in Github actions. See #506 for more details. Once the PR is merged you may rebase your branch on top of the latest. |
|
@periklis92 , can you please add a test that covers scenario from the issue? |
|
The build seems to work now. I'll fix the code smell and clean the commits before the final push. |
|
@periklis92 , I mean |
|
Kudos, SonarCloud Quality Gate passed! |








Split Enumerator strings would have the wrong length if the string started with the separator.
This refers to issue #500 and this fix seems to have solved it.