Skip to content

Deprecate SupportLastInObjectIterations#482

Merged
probot-auto-merge[bot] merged 2 commits intoHandlebars-Net:masterfrom
orgads:deprecate-support-last
Dec 23, 2021
Merged

Deprecate SupportLastInObjectIterations#482
probot-auto-merge[bot] merged 2 commits intoHandlebars-Net:masterfrom
orgads:deprecate-support-last

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Dec 20, 2021

No description provided.

@orgads orgads mentioned this pull request Dec 20, 2021
Merged
oformaniuk
oformaniuk reviewed Dec 20, 2021
View reviewed changes
oformaniuk
oformaniuk requested changes Dec 20, 2021
View reviewed changes
@oformaniuk oformaniuk linked an issue Dec 20, 2021 that may be closed by this pull request
Supporting @last for object iteration by default #480
Closed
oformaniuk
oformaniuk reviewed Dec 21, 2021
View reviewed changes
@orgads orgads force-pushed the deprecate-support-last branch 7 times, most recently from ab41562 to 5b19ef4 Compare December 22, 2021 09:00
@oformaniuk oformaniuk added this to the v3 milestone Dec 22, 2021
@oformaniuk
Copy link
Member

oformaniuk commented Dec 22, 2021

Removal of ObjectIteratorValues introduces breaking change to current v2 API as some external users (e.g., Handlebars.Net.Extension.NewtonsoftJson and Handlebars.Net.Extension.Json) depends on current behavior.
I'd merge this PR to the new upstream to track v3 milestone

@orgads
Copy link
Contributor Author

orgads commented Dec 23, 2021

I can revert the file deletion, and mark it as obsolete. Then you can remove it on v3. WDYT?

@oformaniuk
Copy link
Member

oformaniuk commented Dec 23, 2021

I can revert the file deletion, and mark it as obsolete. Then you can remove it on v3. WDYT?

In that case we'd need to revert addition of Key to IteratorValues and leave TODO mentioning the intent to do the change.

@orgads
Deprecate SupportLastInObjectIterations
0bc5e07
@orgads
Purge ObjectIteratorValues
0d363bf 
Support Key for all iterators (non-object iterators return the same
value as @index).
@orgads orgads force-pushed the deprecate-support-last branch from 5b19ef4 to 0d363bf Compare December 23, 2021 06:18
@orgads
Copy link
Contributor Author

orgads commented Dec 23, 2021

Why? I just re-added the class, and added [Obsolete] attribute, so extensions can still use it.

Is it ok?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
22.9% 22.9% Duplication

@probot-auto-merge probot-auto-merge bot merged commit ec6fec7 into Handlebars-Net:master Dec 23, 2021
@orgads orgads deleted the deprecate-support-last branch December 23, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oformaniuk oformaniuk oformaniuk approved these changes

Assignees

No one assigned

Labels

breaking change enhancement handlebars lang compatibility

Projects

None yet

Milestone

v3

Development

Successfully merging this pull request may close these issues.

Supporting @last for object iteration by default

2 participants

@orgads @oformaniuk