Open
Conversation
Contributor
|
The bitrate control should be disable like for FLAC and ALAC. It looks like something is wrong when muxing to MP4, QuickTime Player ignores the track: Either libavformat is setting some wrong values, or Apple software can't read PCM stored this way. |
Contributor
Author
|
I will investigate. |
Contributor
Author
|
Quicktime should be working now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change:
Add PCM passthru and PCM encoding for all 3 platforms. It misses a checkbox for PCM passthru in AudioDefaults.xib because I didn't know where to put it. This will fix #950.
I have tested PCM passthru with a video file of my Sony camera (pcm_s24be audio stream) and encoding to 16-bit and 24-bit PCM with different samples.
Tested on: