Fix script directory handling in generate-favicons.sh#49
Closed
Fix script directory handling in generate-favicons.sh#49
Conversation
- Added script to generate all favicon sizes from SVG source with proper color handling - Updated apple-touch-icon sizes (180x180 primary, added 152x152 for iPad) - Changed msapplication-TileColor from black to brand blue (#0085E8)
Use any as per For vector formats like SVG, you can use any to indicate scalability. https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest/Reference/icons#sizes Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
Copilot
AI
changed the title
[WIP] Update favicon upgrade implementation based on feedback
Fix script directory handling in generate-favicons.sh
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses reviewer feedback on PR #46 regarding temporary file creation in arbitrary directories.
Changes
favicon-source.svgis consistently created and cleaned up from project rootThis prevents temporary file pollution across different working directories and ensures cleanup always targets the correct location.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.