Confirm generate-favicons.sh already fails on missing directory#47
Closed
Confirm generate-favicons.sh already fails on missing directory#47
Conversation
- Added script to generate all favicon sizes from SVG source with proper color handling - Updated apple-touch-icon sizes (180x180 primary, added 152x152 for iPad) - Changed msapplication-TileColor from black to brand blue (#0085E8)
Merged
Copilot
AI
changed the title
[WIP] Fix favicon upgrade to handle missing folder case
Confirm generate-favicons.sh already fails on missing directory
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback requesting the script fail if
public/static/faviconsdoesn't exist rather than creating it automatically.No code changes required - the script already implements this behavior:
set -ecauses exit on first errormkdir -ppresent in scriptmagickcommand failureThe current implementation in
25bfc8amatches the requested behavior.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.