Created Team Pics component for Home-page#77
Merged
maryharebear merged 2 commits intofeat/home-pagefrom Jun 5, 2020
Merged
Conversation
The code is not responsive, so I will / we will have to change it later on.
trumanjchan
requested review from
adriandarian,
athsiao,
maryharebear and
shiv248
|
Warnings are found on analyzing the commit 1279538. 3 warnings: We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure If you are struggling with these errors or warnings, feel free to ask us via chat. 💬 |
maryharebear
requested changes
Jun 1, 2020
Member
maryharebear
left a comment
maryharebear
left a comment
There was a problem hiding this comment.
Need to be responsive and use the Component className from your tsx file in your scss so its your own style and it wont affect others.
Member
|
Also, can you please fill out the description. Thank you! |
I used a different source online that had code for a responsive hexagon design, and edited it. I also added media queries for the Header of the component, "Our Team", so the font-size changes based on a specified resolution's width. We also decided not to use the linkedIn photos because the default resolution on those are too small, and would need to be scaled. For now, there are placeholders because members need to upload their photos into our Google Drive.
maryharebear
approved these changes
Jun 5, 2020
adriandarian
pushed a commit
that referenced
this pull request
Oct 18, 2021
Created Team Pics component for Home-page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is not responsive, so I will / we will have to change it later on.
Proposed changes
We don't have a Team Pics component yet.
6/3/2020 Edit:
Members need to upload their photos into our Google Drive. Then their photo placeholders in the tsx file needs to be changed.
Types of changes
What types of changes does your code introduce to Appium?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Description
Made Responsive w/Queries on 6/3/2020. I followed this guide, https://www.codesmite.com/article/how-to-create-pure-css-hexagonal-grids, to create the hexagon honeycomb design. I also included media queries for the component's Header, and lots of comments in the scss file. What still needs to be changed are the placeholders in the tsx file. HackMerced members need to upload their photo onto our Google Drive (HackMerced>Website>the HUB>Team Pictures). In the tsx file, the src={...} will then need to be changed to their NAME.