Skip to content

Revert "Feat/navbar"#61

Merged
adriandarian merged 1 commit intomasterfrom
revert-60-feat/navbar
Sep 24, 2018
Merged

Revert "Feat/navbar"#61
adriandarian merged 1 commit intomasterfrom
revert-60-feat/navbar

Conversation

@adriandarian
Copy link
Copy Markdown
Member

Reverts #60

@adriandarian
Copy link
Copy Markdown
Member Author

image

@adriandarian adriandarian added bug Something isn't working help wanted Extra attention is needed invalid This doesn't seem right Front End labels Sep 10, 2018
@adriandarian adriandarian added this to the Initial Design Scheme milestone Sep 14, 2018

var FontAwesome = require('react-fontawesome');

class Footer extends Component {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should convert this component to a stateless component since it (has no state) and to avoid unnecessary rerenders!

@adriandarian adriandarian merged commit 5b5a317 into master Sep 24, 2018
@adriandarian adriandarian deleted the revert-60-feat/navbar branch September 26, 2018 06:51
adriandarian added a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working help wanted Extra attention is needed invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants