Skip to content

Feat/mailchimp#224

Open
AlissonRoss wants to merge 18 commits intodevelopfrom
feat/mailchimp
Open

Feat/mailchimp#224
AlissonRoss wants to merge 18 commits intodevelopfrom
feat/mailchimp

Conversation

@AlissonRoss
Copy link
Copy Markdown
Member

@AlissonRoss AlissonRoss commented Nov 4, 2022

Proposed changes

Mailchimp subscription integration through embedded HTML Component.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [X ] I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • [X ] Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • [X ] iPad
  • iPad Pro

Desktops

  • [X ] Windows 10
  • MacOSX
  • Ubuntu

Screenshots

Please attach at least one Desktop and Mobile screenshot of your update.
Firefox Windows Version 106.0.3 (64-bit)
image

iPad

image

After the user click the "Subscribe" button, they are taken to a new page in a new tab that looks like this:
image

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@AlissonRoss AlissonRoss requested a review from athsiao November 4, 2022 20:18
@github-actions github-actions bot added the react label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants