Skip to content

Started the LHD: Learn page#186

Merged
trumanjchan merged 1 commit intodevelopfrom
learnday-navbar_render
Sep 21, 2021
Merged

Started the LHD: Learn page#186
trumanjchan merged 1 commit intodevelopfrom
learnday-navbar_render

Conversation

@trumanjchan
Copy link
Copy Markdown
Contributor

@trumanjchan trumanjchan commented Sep 21, 2021

Proposed changes

Rendered the Navbar component on the MLH Local Hack Day: Learn (LHD:L) page to start. The MLH Banner is stickied on every HackMerced page, so that's one less task.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • [] Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

image
image

Further comments

Didn't need to render the MLH Banner as it is already default rendered on every HackMerced page. Didn't know that until now, nice.

Rendered the Navbar component on the page to start. The MLH Banner is stickied on every HackMerced page, so that's one less task.
@trumanjchan trumanjchan added the New Feature New feature label Sep 21, 2021
@trumanjchan trumanjchan self-assigned this Sep 21, 2021
@github-actions github-actions bot added the react label Sep 21, 2021
@trumanjchan trumanjchan merged commit 3a4a921 into develop Sep 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the learnday-navbar_render branch September 21, 2021 02:32
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant