Skip to content

Feat/image convert webp#185

Merged
trumanjchan merged 22 commits intodevelopfrom
feat/image-convert-webp
Sep 1, 2021
Merged

Feat/image convert webp#185
trumanjchan merged 22 commits intodevelopfrom
feat/image-convert-webp

Conversation

@AlissonRoss
Copy link
Copy Markdown
Member

Proposed changes

Converted .PNG and .JPG images to the WebP format. Also added fallback code through usage of the picture tag and SrcSet.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ X] I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • [X ] Chrome
  • [X ] Firefox
  • Edge
  • [ X] Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • [X ] iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • [X ] Windows 10
  • MacOSX
  • Ubuntu

Screenshots

image
image

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the react label Aug 23, 2021
AlissonRoss and others added 11 commits August 25, 2021 12:34
The picture tag was making it so the HackMerced role text wouldn't show up when the user hovers the hexagons.
The picture tag was making it so the HackMerced role text wouldn't show up when the user hovers the hexagons.
Adding the <picture> tag around our team picture messed up the CSS, so I decided to revamp the entire component, making use of grid. This allows the picture tag to be used, which is important for browser fallback if webp image file type is not supported.
@trumanjchan trumanjchan self-requested a review September 1, 2021 04:00
@trumanjchan trumanjchan added the New Feature New feature label Sep 1, 2021
@trumanjchan trumanjchan merged commit 67b499b into develop Sep 1, 2021
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants