Skip to content

Fix/sponsors logos darkmode#182

Merged
trumanjchan merged 2 commits intodevelopfrom
fix/sponsors-logos_darkmode
Jul 30, 2021
Merged

Fix/sponsors logos darkmode#182
trumanjchan merged 2 commits intodevelopfrom
fix/sponsors-logos_darkmode

Conversation

@trumanjchan
Copy link
Copy Markdown
Contributor

Proposed changes

I added more sponsors' logos to the component, and manually edited each logo so they all seem to have the same aspect ratio (thank you paint.net). I also had to replace three current logos where their colors are not their original color. I edited the page to make the code easier to follow. Increased the animation duration. For the Contact Us Page, I got rid of some blank space, cleaned up code by grouping divs together, and adding a mouse hover effect.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

After:
image
image
image
image
image

Further comments

Mary said it was fine that the sponsor logos have white pixels and are hard to read when in dark mode. As long as the logos are visible, the same aspect ratio, and are the company's original logo colors, in light mode.

@trumanjchan trumanjchan added the Fix Fixing a known bug label Jul 30, 2021
@trumanjchan trumanjchan self-assigned this Jul 30, 2021
@github-actions github-actions bot added the react label Jul 30, 2021
@trumanjchan trumanjchan merged commit ced7316 into develop Jul 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/sponsors-logos_darkmode branch July 30, 2021 02:59
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fixing a known bug react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant