Merged
Conversation
adriandarian
pushed a commit
that referenced
this pull request
Oct 18, 2021
Fix/sponsors logos darkmode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
I added more sponsors' logos to the component, and manually edited each logo so they all seem to have the same aspect ratio (thank you paint.net). I also had to replace three current logos where their colors are not their original color. I edited the page to make the code easier to follow. Increased the animation duration. For the Contact Us Page, I got rid of some blank space, cleaned up code by grouping divs together, and adding a mouse hover effect.
Types of changes
What types of changes does your code introduce to HackMerced Hub?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Responsiveness
Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments
Browsers
Devices
Phones
Tablets
Desktops
Screenshots
After:





Further comments
Mary said it was fine that the sponsor logos have white pixels and are hard to read when in dark mode. As long as the logos are visible, the same aspect ratio, and are the company's original logo colors, in light mode.