Skip to content

Fixed Sponsers&ContactUs page format#181

Merged
trumanjchan merged 1 commit intodevelopfrom
fix/Sponsers&ContactUs-page_format
Jul 30, 2021
Merged

Fixed Sponsers&ContactUs page format#181
trumanjchan merged 1 commit intodevelopfrom
fix/Sponsers&ContactUs-page_format

Conversation

@Erickkk-202
Copy link
Copy Markdown
Contributor

Fixed the format for the Sponsers&ContactUs page so it wouldn't show the white bars when width is less than 500px. Also, I Resized the form box so it wouldn't cut off when reaching 500px or less.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Fixed the format for the Sponsers&ContactUs page so it wouldn't show the white bars when width is less than 500px. Also, I Resized the form box so it wouldn't cut off when reaching 500px or less.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • [ x] Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • [ x] Moto G4
  • [ x] Galaxy S5
  • [ x] Pixel 2
  • [x ] Pixel 2 XL
  • [ x] iPhone 5/SE
  • [ x] iPhone 6/7/8
  • [x ] iPhone 6/7/8 Plus
  • [x ] iPhone X

Tablets

  • [ x] iPad
  • [x ] iPad Pro

Desktops

  • [ x] Windows 10
  • MacOSX
  • Ubuntu

Screenshots

Please attach at least one Desktop and Mobile screenshot of your update.
image

image

image

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Fixed the format for the Sponsers&ContactUs page so it wouldn't show the white bars when width is less than 500px. Also, I Resized the form box so it wouldn't cut off when reaching 500px or less.
@Erickkk-202 Erickkk-202 requested a review from trumanjchan July 24, 2021 21:58
@Erickkk-202 Erickkk-202 self-assigned this Jul 24, 2021
@github-actions github-actions bot added the react label Jul 24, 2021
@trumanjchan trumanjchan added the Fix Fixing a known bug label Jul 30, 2021
@trumanjchan trumanjchan merged commit 3f022c1 into develop Jul 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/Sponsers&ContactUs-page_format branch July 30, 2021 02:01
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
…ormat

Fixed Sponsers&ContactUs page format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fixing a known bug react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants