Fixed Past-Sponsors-Logos Component code messing with Home Page imgs#180
Merged
trumanjchan merged 1 commit intodevelopfrom Jul 11, 2021
Merged
Fixed Past-Sponsors-Logos Component code messing with Home Page imgs#180trumanjchan merged 1 commit intodevelopfrom
trumanjchan merged 1 commit intodevelopfrom
Conversation
Made the Sponsor-Us Page scss and HTML code more readable. Got rid of useless code. Changed 'id' to 'className'. In the scss file, '.img{}' and '#' were messing up the aspect ratio of images on the Home Page, and Sponsor Us Page. The mobile view 'X' button in the hamburger menu was out of view, but it is now visible again.
adriandarian
pushed a commit
that referenced
this pull request
Oct 18, 2021
Fixed Past-Sponsors-Logos Component code messing with Home Page imgs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Made the Sponsor-Us Page scss and HTML code more readable. Got rid of useless code. Changed 'id' to 'className'. In the scss file, '.img{}' and '#' were messing up the aspect ratio of images on the Home Page, and Sponsor Us Page. The mobile view 'X' button in the hamburger menu was out of view, but it is now visible again.
Types of changes
What types of changes does your code introduce to HackMerced Hub?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Responsiveness
Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments
Browsers
Devices
Phones
Tablets
Desktops
Screenshots
Before These Commits (develop branch):




After These Changes:




Further comments
Shakti's changes, Sponsors Page's Our-Past-Sponsors Component had code that were messing up aspect ratios of images ('HackMerced' Title img and 'About Us' Section's img) on the Home Page. Code also moved the location of mobile view's hamburger menu 'X' button.