Skip to content

Connected the Logo with the official website of MLH#179

Merged
trumanjchan merged 5 commits intodevelopfrom
logolinking
Jul 14, 2021
Merged

Connected the Logo with the official website of MLH#179
trumanjchan merged 5 commits intodevelopfrom
logolinking

Conversation

@shaktiv29
Copy link
Copy Markdown
Member

Proposed changes

I connected the MLH Banner with official website of MLH.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

https://jabalpurengineering-my.sharepoint.com/:i:/g/personal/shaktiv_jecjabalpur_ac_in/Ecf2ZKTZYpJKsOhneOOWiLYBsFH-KBSB1YCOXnT-D0ek0A?e=9b2nJ9

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the react label Jul 11, 2021
@trumanjchan trumanjchan self-requested a review July 11, 2021 20:36
@trumanjchan trumanjchan added the Fix Fixing a known bug label Jul 11, 2021
trumanjchan and others added 4 commits July 11, 2021 14:41
Made the Sponsor-Us Page scss and HTML code more readable. Got rid of useless code. Changed 'id' to 'className'. In the scss file, '.img{}' and '#' were messing up the aspect ratio of images on the Home Page, and Sponsor Us Page. The mobile view 'X' button in the hamburger menu was out of view, but it is now visible again.
Fixed Past-Sponsors-Logos Component code messing with Home Page imgs
@trumanjchan trumanjchan merged commit 5d96357 into develop Jul 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the logolinking branch July 14, 2021 17:24
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Connected the Logo with the official website of MLH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fixing a known bug react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants