Skip to content

Fix Footer Icons and copyright year#176

Merged
trumanjchan merged 1 commit intodevelopfrom
fix/home_footer
Jun 30, 2021
Merged

Fix Footer Icons and copyright year#176
trumanjchan merged 1 commit intodevelopfrom
fix/home_footer

Conversation

@rvemuri2
Copy link
Copy Markdown
Contributor

@rvemuri2 rvemuri2 commented Jun 30, 2021

Changed the slack icon to youtube icon, fixed the hyperlink. Changed the 2020 copyright to 2021

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x ] I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] I have added necessary documentation (if appropriate)
  • [ x] Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • [ x] Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • [ x] MacOSX
  • Ubuntu

Screenshots

working

Further comments

The solution for this was really simple, I just changed a few lines of codes to make it look like the Youtube icon and changed the year to 2021. I just copy pasted the youtube link into the reference.

I fixed the slack icon to the youtube icon, changed the hyperlink, and changed the copyright year.
@github-actions github-actions bot added the react label Jun 30, 2021
@rvemuri2 rvemuri2 requested a review from trumanjchan June 30, 2021 06:33
@rvemuri2 rvemuri2 self-assigned this Jun 30, 2021
@rvemuri2 rvemuri2 added the Fix Fixing a known bug label Jun 30, 2021
@trumanjchan trumanjchan merged commit 21ff4e3 into develop Jun 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/home_footer branch June 30, 2021 06:34
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Fix Footer Icons and copyright year
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fixing a known bug react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants