Skip to content

Sponsors component#174

Merged
trumanjchan merged 26 commits intodevelopfrom
sponsors-component
Jul 7, 2021
Merged

Sponsors component#174
trumanjchan merged 26 commits intodevelopfrom
sponsors-component

Conversation

@shaktiv29
Copy link
Copy Markdown
Member

@shaktiv29 shaktiv29 commented Jun 23, 2021

Proposed changes

Hello, I have updated the sponsors section. I have added logos of our past sponsors.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

https://jabalpurengineering-my.sharepoint.com/:i:/g/personal/shaktiv_jecjabalpur_ac_in/EZ4A-pzDHJlNkQds175JgsQBdSXxkJQuYJtk_BipY8bZAQ?e=ZhqcGq

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

maryharebear and others added 8 commits March 25, 2021 18:57
Responsiveness Tower and White dots on past winners fix
Merging Develop with Master
Merge develop fix for widescreens to master
Upon selecting text in website, background colour becomes #FB9300 and text colour becomes black.
@github-actions github-actions bot added the react label Jun 23, 2021
@trumanjchan
Copy link
Copy Markdown
Contributor

trumanjchan commented Jun 23, 2021

The responsiveness is good!
But you still need to work on:

  1. All logos need to be the same size as each other and centered in their cells
  2. Logos need a transparent background
  3. You need to make it so when the User clicks a logo, it links to their company's website
  4. Change your PR so it compares Your Branch to Develop (you have it comparing to Master right now)
  5. (Optional) Add a mouse-hover animation for all logos

Also, please add a screenshot to your PR under Screenshots section.

Text selection colour is now white with background colour of #F3C583
@shaktiv29
Copy link
Copy Markdown
Member Author

Okay!!

@shaktiv29 shaktiv29 changed the base branch from master to develop June 24, 2021 07:10
Abdus-Samee and others added 13 commits June 24, 2021 21:56
Upon selecting text in website, background colour becomes #FB9300 and text colour becomes black.
Text selection colour is now white with background colour of #F3C583
I fixed the slack icon to the youtube icon, changed the hyperlink, and changed the copyright year.
Fix Footer Icons and copyright year
grouped the icon, title, and project name into one Div
Created the component that has two clickable divs that bring you to their respective google forms: mentors or volunteers. Made this component responsive. Added a hover animation!
Created 'Contribute!' Component & added Hover Animation
@trumanjchan trumanjchan self-requested a review July 6, 2021 23:51
@trumanjchan trumanjchan added the New Feature New feature label Jul 6, 2021
@trumanjchan trumanjchan merged commit 8bfea80 into develop Jul 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the sponsors-component branch July 7, 2021 07:27
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants