Skip to content

fixed tower size and checked for different width responses#173

Merged
trumanjchan merged 5 commits intodevelopfrom
fix/towerSize
Jun 23, 2021
Merged

fixed tower size and checked for different width responses#173
trumanjchan merged 5 commits intodevelopfrom
fix/towerSize

Conversation

@Erickkk-202
Copy link
Copy Markdown
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

The changes I made were fixing the tower height and checking its response to different width sizes.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • [ x] Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • [x ] Moto G4
  • [x ] Galaxy S5
  • [x ] Pixel 2
  • [x ] Pixel 2 XL
  • [x ] iPhone 5/SE
  • [x ] iPhone 6/7/8
  • [x ] iPhone 6/7/8 Plus
  • [x ] iPhone X
  • The tower doesn't appear until the width reaches 775px

Tablets

  • [ x] iPad
  • [x ] iPad Pro

Desktops

  • [x ] Windows 10
  • MacOSX
  • Ubuntu

Screenshots

Please attach at least one Desktop and Mobile screenshot of your update.
tower

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Erickkk-202 Erickkk-202 added the refactor clean up or redo code label Jun 23, 2021
@Erickkk-202 Erickkk-202 requested a review from trumanjchan June 23, 2021 08:20
@Erickkk-202 Erickkk-202 self-assigned this Jun 23, 2021
@github-actions github-actions bot added the react label Jun 23, 2021
Copy link
Copy Markdown
Contributor

@trumanjchan trumanjchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a commit where you remove this block of code, as it makes the tower floating under 1000px width:

image

@trumanjchan trumanjchan merged commit 4027d7d into develop Jun 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/towerSize branch June 23, 2021 23:10
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
fixed tower size and checked for different width responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

react refactor clean up or redo code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants