Skip to content

Feat: Text selection colour change#172

Merged
trumanjchan merged 11 commits intodevelopfrom
feat/textselection-color
Jun 24, 2021
Merged

Feat: Text selection colour change#172
trumanjchan merged 11 commits intodevelopfrom
feat/textselection-color

Conversation

@Abdus-Samee
Copy link
Copy Markdown
Member

@Abdus-Samee Abdus-Samee commented Jun 23, 2021

Upon selecting text in website, background colour becomes #FB9300 and text colour becomes black.

Proposed changes

Added a new feature to the website - colour change on text selection. In both the light and dark modes, the text selection colour is black and the background colour is #FB9300.

Types of changes

What types of changes does your code introduce to HackMerced Hub?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Responsiveness

Check off the different browsers and devices you have tested on. Note: testing includes Horizontal and Vertical alignments

Browsers

  • Chrome
  • Firefox
  • Edge
  • Safari
  • Brave
  • Opera

Devices

Phones

  • Moto G4
  • Galaxy S5
  • Pixel 2
  • Pixel 2 XL
  • iPhone 5/SE
  • iPhone 6/7/8
  • iPhone 6/7/8 Plus
  • iPhone X

Tablets

  • iPad
  • iPad Pro

Desktops

  • Windows 10
  • MacOSX
  • Ubuntu

Screenshots

Please attach at least one Desktop and Mobile screenshot of your update.
Capture1
Capture2

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Erickkk-202 and others added 2 commits June 22, 2021 17:30
Upon selecting text in website, background colour becomes #FB9300 and text colour becomes black.
@Abdus-Samee Abdus-Samee added the New Feature New feature label Jun 23, 2021
@Abdus-Samee Abdus-Samee requested a review from trumanjchan June 23, 2021 07:25
@Abdus-Samee Abdus-Samee self-assigned this Jun 23, 2021
@github-actions github-actions bot added the react label Jun 23, 2021
Changed the towers height for 1000px max-width

changed to 750 to 1050
@trumanjchan
Copy link
Copy Markdown
Contributor

Hi Abdus,

(1) Can you make the highlight color a lighter color of orange? Preferably as light or lighter than the color of the breaklines:
image
(2) Also, when highlighted, change the text color to White (not black).

@trumanjchan
Copy link
Copy Markdown
Contributor

@Abdus-Samee Looks good now! Can you drag your branch on top of your Local develop branch and click Rebase?

Upon selecting text in website, background colour becomes #FB9300 and text colour becomes black.
Text selection colour is now white with background colour of #F3C583
@trumanjchan trumanjchan merged commit f4d7eb2 into develop Jun 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/textselection-color branch June 24, 2021 20:41
adriandarian pushed a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants